harishch1998 commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1544095514
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -78,6 +80,8 @@ public class HTTPClient implements RESTClient {
private static final int REST_MAX_CONNECTIONS_DEFAULT = 100;
private static final String REST_MAX_CONNECTIONS_PER_ROUTE =
"rest.client.connections-per-route";
private static final int REST_MAX_CONNECTIONS_PER_ROUTE_DEFAULT = 100;
+ @VisibleForTesting static final String REST_CONNECTION_TIMEOUT =
"rest.client.connection-timeout";
+ @VisibleForTesting static final String REST_SOCKET_TIMEOUT =
"rest.client.socket-timeout";
Review Comment:
Yeah, these are milliseconds. I'll fix the naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
