TheNeuralBit commented on code in PR #10079:
URL: https://github.com/apache/iceberg/pull/10079#discussion_r1552085818
##########
format/spec.md:
##########
@@ -245,19 +245,19 @@ For example, a file may be written with schema `1: a int,
2: b string, 3: c doub
Tables may also define a property `schema.name-mapping.default` with a JSON
name mapping containing a list of field mapping objects. These mappings provide
fallback field ids to be used when a data file does not contain field id
information. Each object should contain
-* `names`: A required list of 0 or more names for a field.
+* `names`: A required list of 0 or more names for a field.
* `field-id`: An optional Iceberg field ID used when a field's name is present
in `names`
* `fields`: An optional list of field mappings for child field of structs,
maps, and lists.
Field mapping fields are constrained by the following rules:
-* A name may contain `.` but this refers to a literal name, not a nested
field. For example, `a.b` refers to a field named `a.b`, not child field `b` of
field `a`.
-* Each child field should be defined with their own field mapping under
`fields`.
Review Comment:
Done
##########
format/spec.md:
##########
@@ -314,7 +314,7 @@ Partition field IDs must be reused if an existing partition
spec contains an equ
|-------------------|--------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------|-------------|
| **`identity`** | Source value, unmodified
| Any
| Source type |
| **`bucket[N]`** | Hash of value, mod `N` (see below)
| `int`, `long`, `decimal`, `date`, `time`, `timestamp`, `timestamptz`,
`timestamp_ns`, `timestamptz_ns`, `string`, `uuid`, `fixed`, `binary` | `int`
|
-| **`truncate[W]`** | Value truncated to width `W` (see below)
| `int`, `long`, `decimal`, `string`
| Source type |
+| **`truncate[W]`** | Value truncated to width `W` (see below)
| `int`, `long`, `decimal`, `string`, `binary`
| Source type |
Review Comment:
Done! Please check my language and example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
