nastra commented on code in PR #10053:
URL: https://github.com/apache/iceberg/pull/10053#discussion_r1547290305
##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -448,6 +446,47 @@ static HttpRequestInterceptor loadInterceptorDynamically(
return instance;
}
+ static HttpClientConnectionManager configureConnectionManager(
+ Map<String, String> properties, ConnectionConfig connectionConfig) {
Review Comment:
rather than passing in the `ConnectionConfig` I would probably just call
`configureConnectionConfig(properties)` inside `configureConnectionManager(..)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
