marvinlanhenke commented on code in PR #312:
URL: https://github.com/apache/iceberg-rust/pull/312#discussion_r1545981170
##########
crates/iceberg/src/transform/temporal.rs:
##########
@@ -175,7 +200,7 @@ impl TransformFunction for Day {
.as_any()
.downcast_ref::<TimestampMicrosecondArray>()
.unwrap()
- .unary(|v| -> i32 { Self::day_timestamp_micro(v) }),
+ .unary(|v| -> i32 { Self::day_timestamp_micro(v).unwrap() }),
Review Comment:
@liurenjie1024
can we handle the unwrap() properly, haven't found a way yet. But perhaps
you have an idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]