HonahX commented on code in PR #559:
URL: https://github.com/apache/iceberg-python/pull/559#discussion_r1544024793
##########
pyiceberg/table/__init__.py:
##########
@@ -1010,6 +1053,13 @@ def append(self, df: pa.Table) -> None:
if len(self.spec().fields) > 0:
raise ValueError("Cannot write to partitioned tables")
+ from pyiceberg.io.pyarrow import schema_to_pyarrow
+
+ _check_schema_compatible(self.schema(), other_schema=df.schema)
+ # cast if the two schemas are compatible but not equal
+ if schema_to_pyarrow(self.schema()) != df.schema:
+ df = df.cast(schema_to_pyarrow(self.schema()))
Review Comment:
Need to use `schema_to_pyarrow` directly here since `schema.as_arrow()` is
not available in 0.6.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
