Fokko commented on code in PR #277:
URL: https://github.com/apache/iceberg-rust/pull/277#discussion_r1541095666


##########
crates/iceberg/src/arrow.rs:
##########
@@ -106,3 +114,224 @@ impl ArrowReader {
         ProjectionMask::all()
     }
 }
+
+/// The key of column id in the metadata of arrow field.
+pub const COLUMN_ID_META_KEY: &str = "column_id";

Review Comment:
   This is a tricky one. In Arrow the `PARQUET:` prefix indicates that it is 
something specific to Parquet, in this case the 
[`field_id`](https://github.com/apache/parquet-format/blob/e517ac4dbe08d518eb5c2e58576d4c711973db94/src/main/thrift/parquet.thrift#L459).
   
   Would be awesome if we could add a test for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to