tomtongue commented on code in PR #10039:
URL: https://github.com/apache/iceberg/pull/10039#discussion_r1539799719
##########
core/src/test/java/org/apache/iceberg/TestMetrics.java:
##########
@@ -766,24 +771,38 @@ protected void assertCounts(int fieldId, Long valueCount,
Long nullValueCount, M
protected void assertCounts(
int fieldId, Long valueCount, Long nullValueCount, Long nanValueCount,
Metrics metrics) {
- Map<Integer, Long> valueCounts = metrics.valueCounts();
- Map<Integer, Long> nullValueCounts = metrics.nullValueCounts();
- Map<Integer, Long> nanValueCounts = metrics.nanValueCounts();
- Assert.assertEquals(valueCount, valueCounts.get(fieldId));
- Assert.assertEquals(nullValueCount, nullValueCounts.get(fieldId));
- Assert.assertEquals(nanValueCount, nanValueCounts.get(fieldId));
+ assertThat(metrics.valueCounts())
+ .satisfiesAnyOf(
Review Comment:
Change this part like the previous tests. If `containsEntry` is used, it's
also possible to write like:
```java
assertThat(metrics.valueCounts()).satisfies(
valueCounts -> {
if (valueCounts.containsKey(fieldId))
assertThat(valueCounts).containsEntry(fieldId, valueCount);
else assertThat(valueCounts).doesNotContainKey(fieldId);
}
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
