nastra commented on code in PR #10037:
URL: https://github.com/apache/iceberg/pull/10037#discussion_r1538851136
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSnapshotTableProcedure.java:
##########
@@ -223,4 +223,31 @@ public void testInvalidSnapshotsCases() throws IOException
{
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Cannot handle an empty identifier for argument table");
}
+
+ @TestTemplate
+ public void testSnapshotWithParallelism() throws IOException {
+ String location = Files.createTempDirectory(temp,
"junit").toFile().toString();
+ sql(
+ "CREATE TABLE %s (id bigint NOT NULL, data string) USING parquet
LOCATION '%s'",
+ sourceName, location);
+ sql("INSERT INTO TABLE %s VALUES (1, 'a')", sourceName);
+ sql("INSERT INTO TABLE %s VALUES (2, 'b')", sourceName);
+ Object result =
+ scalarSql(
+ "CALL %s.system.snapshot(source_table => '%s', table => '%s',
parallelism => 2)",
+ catalogName, sourceName, tableName);
+
+ assertThat(result).as("Should have added two files").isEqualTo(2L);
+
+ Table createdTable = validationCatalog.loadTable(tableIdent);
+ String tableLocation = createdTable.location();
+ assertThat(tableLocation)
+ .as("Table should not have the original location")
+ .isNotEqualTo(location);
+
+ assertEquals(
+ "Should have expected rows",
+ ImmutableList.of(row(1L, "a"), row(2L, "b")),
+ sql("SELECT * FROM %s ORDER BY id", tableName));
Review Comment:
```suggestion
assertThat(sql("SELECT * FROM %s ORDER BY id",
tableName))).containsExactly(row(1L, "a"), row(2L, "b"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
