nastra commented on code in PR #9980:
URL: https://github.com/apache/iceberg/pull/9980#discussion_r1535428308
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java:
##########
@@ -349,8 +351,70 @@ public void testListTables() throws TException,
IOException {
HIVE_METASTORE_EXTENSION.metastoreClient().dropTable(DB_NAME,
hiveTableName);
}
- private org.apache.hadoop.hive.metastore.api.Table createHiveTable(String
hiveTableName)
- throws IOException {
+ @Test
+ public void testHiveTableAndIcebergTableWithSameName() throws TException,
IOException {
+ List<TableIdentifier> tableIdents =
catalog.listTables(TABLE_IDENTIFIER.namespace());
+ assertThat(tableIdents).as("should be 1 table in namespace .").hasSize(1);
Review Comment:
```suggestion
assertThat(catalog.listTables(TABLE_IDENTIFIER.namespace())).hasSize(1).containsExactly(...);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
