viirya opened a new pull request, #293: URL: https://github.com/apache/iceberg-rust/pull/293
While I'm looking into #286, I found there is one function `add_manifest_entries` which is confusing to me. In fact, it writes manifest instead of manifest entries. As I think manifest entries (i.e., `ManifestEntry`) should refer to the entries inside manifest (i.e., `Manifest`). I think updating the function names and a few comments make it less confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
