RussellSpitzer commented on code in PR #9998:
URL: https://github.com/apache/iceberg/pull/9998#discussion_r1532882743
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java:
##########
@@ -185,8 +185,21 @@ public void flush() throws IOException {
@Override
public void close() throws IOException {
- stream.close();
- this.closed = true;
+ try {
+ stream.close();
+ // {@link org.apache.hadoop.fs.s3a.S3ABlockOutputStream#close()} calls
{@link
+ // org.apache.hadoop.fs.s3a.S3ABlockOutputStream#putObject()}
+ // which doesn't throw an exception when interrupted.
+ // Need to check the interrupted flag to detect failed object upload
+ // and propagate the error up.
+ if (Thread.interrupted()
+ && "org.apache.hadoop.fs.s3a.S3ABlockOutputStream"
Review Comment:
Don't we have access to S3ABlockOutputStream here? Just thinking we should
use the class object to get the name rather than encoding the string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
