marvinlanhenke commented on PR #285: URL: https://github.com/apache/iceberg-rust/pull/285#issuecomment-2009409832
@liurenjie1024 I fixed most of the issues / suggestions - thanks again. Still unresolved / left to discuss: - keeping file_io in `HmsCatalog` - using `flush()` instead of `shutdown()` - possibly simplifiying `HiveSchemaBuilder` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org