liurenjie1024 commented on code in PR #276:
URL: https://github.com/apache/iceberg-rust/pull/276#discussion_r1529565534
##########
crates/iceberg/src/expr/predicate.rs:
##########
@@ -282,15 +282,18 @@ impl Bind for Predicate {
return Ok(BoundPredicate::AlwaysTrue);
}
}
- &PredicateOperator::IsNan | &PredicateOperator::NotNan => {
- if
!bound_expr.term.field().field_type.is_floating_type() {
- return Err(Error::new(
- ErrorKind::DataInvalid,
- format!(
- "Expecting floating point type, but found
{}",
- bound_expr.term.field().field_type
- ),
- ));
+ &PredicateOperator::IsNan => {
+ if
bound_expr.term.field().field_type.is_floating_type()
+ | bound_expr.term.field().required
+ {
+ return Ok(BoundPredicate::AlwaysFalse);
+ }
+ }
+ &PredicateOperator::NotNan => {
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
