liurenjie1024 commented on code in PR #278:
URL: https://github.com/apache/iceberg-rust/pull/278#discussion_r1531421328
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -886,6 +903,51 @@ mod tests {
config_mock.assert_async().await;
}
+ #[tokio::test]
+ async fn test_oauth_with_optional_param() {
+ let mut props = HashMap::new();
+ props.insert("credential".to_string(), "client1:secret1".to_string());
+ props.insert("scope".to_string(), "custom_scope".to_string());
+ props.insert("audience".to_string(), "custom_audience".to_string());
+ props.insert("resource".to_string(), "custom_resource".to_string());
+
+ let mut server = Server::new_async().await;
+ let oauth_mock = server
+ .mock("POST", "/v1/oauth/tokens")
+
.match_body(mockito::Matcher::Regex("scope=custom_scope".to_string()))
+ .match_body(mockito::Matcher::Regex(
+ "audience=custom_audience".to_string(),
+ ))
+ .match_body(mockito::Matcher::Regex(
+ "resource=custom_resource".to_string(),
+ ))
+ .with_status(200)
+ .with_body(
+ r#"{
+ "access_token": "ey000000000000",
+ "token_type": "Bearer",
+ "issued_token_type":
"urn:ietf:params:oauth:token-type:access_token",
+ "expires_in": 86400
+ }"#,
+ )
+ .create_async()
+ .await;
+
+ let config_mock = create_config_mock(&mut server).await;
+
+ let _catalog = RestCatalog::new(
+ RestCatalogConfig::builder()
+ .uri(server.url())
+ .props(props)
+ .build(),
+ )
+ .await
+ .unwrap();
+
+ oauth_mock.assert_async().await;
+ config_mock.assert_async().await;
Review Comment:
How about add a check for the returned token?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
