nastra commented on code in PR #9999:
URL: https://github.com/apache/iceberg/pull/9999#discussion_r1530789489
##########
core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java:
##########
@@ -68,38 +66,38 @@ public void testSpecIsUnpartitionedForVoidTranforms() {
PartitionSpec spec =
PartitionSpec.builderFor(schema).alwaysNull("id").alwaysNull("data").build();
- Assert.assertTrue(spec.isUnpartitioned());
+ assertThat(spec.isUnpartitioned()).isTrue();
}
@Test
public void testSpecInfoUnpartitionedTable() {
PartitionSpec spec = PartitionSpec.unpartitioned();
TestTables.TestTable table = TestTables.create(tableDir, "test", schema,
spec, formatVersion);
- Assert.assertTrue(spec.isUnpartitioned());
- Assert.assertEquals(spec, table.spec());
- Assert.assertEquals(spec.lastAssignedFieldId(),
table.spec().lastAssignedFieldId());
- Assert.assertEquals(ImmutableMap.of(spec.specId(), spec), table.specs());
- Assert.assertNull(table.specs().get(Integer.MAX_VALUE));
+ assertThat(spec.isUnpartitioned()).isTrue();
+ assertThat(table.spec()).isEqualTo(spec);
+
assertThat(table.spec().lastAssignedFieldId()).isEqualTo(spec.lastAssignedFieldId());
+ assertThat(table.specs()).containsEntry(spec.specId(), spec);
Review Comment:
or alternatively you can also use `containsExactly(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
