hililiwei commented on code in PR #533:
URL: https://github.com/apache/iceberg-python/pull/533#discussion_r1530464016
##########
pyiceberg/table/__init__.py:
##########
@@ -1578,6 +1595,120 @@ def to_ray(self) -> ray.data.dataset.Dataset:
return ray.data.from_arrow(self.to_arrow())
+class IncrementalAppendScan(DataScan):
Review Comment:
I'm a bit confused here. Should I modify the inheritance structure? The
current inheritance structure is TableScan -> DataScan ->
IncrementalAppendScan. Should I create a class, like BaseScan, and make both
DataScan and IncrementalAppendScan inherit from it, and move the `snapshot_id`
`snapshot()` from TableScan into DataScan? Like:
```
TableScan
>BaseScan
>DataScan
>IncrementalAppendScan
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
