syun64 commented on code in PR #531:
URL: https://github.com/apache/iceberg-python/pull/531#discussion_r1530323834
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1594,29 +1595,88 @@ def parquet_path_to_id_mapping(
return result
-def fill_parquet_file_metadata(
- data_file: DataFile,
+@dataclass
+class DataFileStatistics:
+ record_count: int
+ column_sizes: Dict[int, int]
+ value_counts: Dict[int, int]
+ null_value_counts: Dict[int, int]
+ nan_value_counts: Dict[int, int]
+ column_aggregates: Dict[int, StatsAggregator]
+ split_offsets: Optional[List[int]] = None
Review Comment:
I just carried its type hint over from the existing DataFile class:
https://github.com/apache/iceberg-python/blob/d3db8401cd006fcbacf1d9a2502248ce4228ff06/pyiceberg/manifest.py#L363
Should it not be optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
