nastra commented on code in PR #9964:
URL: https://github.com/apache/iceberg/pull/9964#discussion_r1528013566
##########
core/src/test/java/org/apache/iceberg/TestManifestWriter.java:
##########
@@ -89,48 +80,44 @@ public void testManifestPartitionStats() throws IOException
{
manifestEntry(Status.DELETED, null, newFile(2,
TestHelpers.Row.of(3))));
List<ManifestFile.PartitionFieldSummary> partitions =
manifest.partitions();
- Assert.assertEquals("Partition field summaries count should match", 1,
partitions.size());
+ assertThat(partitions).hasSize(1);
ManifestFile.PartitionFieldSummary partitionFieldSummary =
partitions.get(0);
- Assert.assertFalse("contains_null should be false",
partitionFieldSummary.containsNull());
- Assert.assertFalse("contains_nan should be false",
partitionFieldSummary.containsNaN());
- Assert.assertEquals(
- "Lower bound should match",
- Integer.valueOf(1),
- Conversions.fromByteBuffer(Types.IntegerType.get(),
partitionFieldSummary.lowerBound()));
- Assert.assertEquals(
- "Upper bound should match",
- Integer.valueOf(3),
- Conversions.fromByteBuffer(Types.IntegerType.get(),
partitionFieldSummary.upperBound()));
+ assertThat(partitionFieldSummary.containsNull()).isFalse();
+ assertThat(partitionFieldSummary.containsNaN()).isFalse();
+ assertThat(
+ (Integer)
Review Comment:
is the casting necessary here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
