marvinlanhenke opened a new issue, #271:
URL: https://github.com/apache/iceberg-rust/issues/271

   ...while working on the HMS catalog, I noticed missing fields (properties & 
snapshots) in the metadata.json when serialized.
   
   Currently we check if e.g. properties `is_empty()` and return `None` - due 
to the serde option flag `None` will be skipped.
   This causes downstream errors, since we need at least an empty object - for 
example `"properties":{}` 
   
https://github.com/apache/iceberg-rust/blob/main/crates/iceberg/src/spec/table_metadata.rs#L730-L737
   
   Another issue I had are the default values for `partition_specs` and 
`sort_orders`. 
   The new `TableMetadataBuilder` does not handle them for now, however we need 
different default values - for example:
   `"partition_specs: [{spec-id: 0, fields []}]"` otherwise I get downstream 
errors as well.
   
https://github.com/apache/iceberg-rust/blob/main/crates/iceberg/src/spec/table_metadata.rs#L328-L335


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to