a-agmon commented on issue #246:
URL: https://github.com/apache/iceberg-rust/issues/246#issuecomment-1998907464
> > Maybe we can also incorporate something like this at this stage. like
adding a _readonly_ property that will default to false, while the StaticTable
sets it as true.
> > ```rust
> > /// Table represents a table in the catalog.
> >
> > #[derive(TypedBuilder, Debug)]
> >
> > pub struct Table {
> >
> > file_io: FileIO,
> >
> > #[builder(default, setter(strip_option, into))]
> >
> > metadata_location: Option<String>,
> >
> > #[builder(setter(into))]
> >
> > metadata: TableMetadataRef,
> >
> > identifier: TableIdent,
> >
> > #[builder(default = false)]
> >
> > readonly: bool,
> >
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > I tried to sketch it
[here](https://github.com/a-agmon/iceberg-rust/blob/feat-add-static-table-2/crates/iceberg/src/table.rs)
for example. I can add this if that seems right.
>
> Looks reasonably to me, thanks for this!
Great! PR is now also updated with changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
