Dysprosium0626 opened a new pull request, #261: URL: https://github.com/apache/iceberg-rust/pull/261
Aiming for https://github.com/apache/iceberg-rust/issues/251. Basically implement `PruneColumn` based on [Java Implementation](https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/types/PruneColumns.java#L42) and add test cases [PyIceberg](https://github.com/apache/iceberg-python/blob/0ee7f1233e062b17b03fccc1eac6449c72e575f0/tests/test_schema.py#L564-L819) One question, how to avoid warning like this(I did know this warning occurs because I never used `PruneColumn::new()` except test cases) ```bash warning: associated function `new` is never used --> crates/iceberg/src/spec/schema.rs:638:8 | 636 | impl PruneColumn { | ---------------- associated function in this implementation 637 | 638 | fn new(selected: HashSet<i32>, select_full_types: bool) -> Self { | ^^^ | = note: `#[warn(dead_code)]` on by default ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
