artyrian commented on PR #9882: URL: https://github.com/apache/iceberg/pull/9882#issuecomment-1991483223
@nastra sure I apologize for the confusion; the revert in the upstream repository was opened by mistake, instead of in a fork, as it was intended for debugging purposes. This revert was an attempt to isolate which dependency might be introducing a breaking change. During the build of release 1.4.3, classes from JDK 21 began to be unexpectedly included in the runtime classpath, causing the build to fail with the error java.lang.IllegalArgumentException: `Unsupported class file major version 65.` It turned out that the issue was not related to Nessie. Instead, it was due to a minor update of the jackson215 dependency specified in Gradle for release 1.4.3, as outlined in the dependency list [here](https://github.com/apache/iceberg/blob/1.4.x/gradle/libs.versions.toml#L40). During the build, jackson215 was at version 2.15.2, but it has since been updated to 2.15.4, which led to the inclusion of JDK 21 classes in the runtime classpath. The specific change between the versions can be found [here](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.15.3...jackson-core-2.15.4#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R219). A proper fix is already present in the main branch for a different reason. To fix the build for the release version, we had to apply the following patch and, just to be safe, lock down all the minor versions: From e9f2ff8bc161360b170a60c68b6050004af4f06c Mon Sep 17 00:00:00 2001 From: artyrian <artyr...@ya.ru> Date: Thu, 7 Mar 2024 02:42:54 +0200 Subject: [PATCH] fix minor version for strictly libs versions ``` --- gradle/libs.versions.toml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index a0fe0df3ba7d..ce61641b8e52 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -19,25 +19,25 @@ delta-core = "2.2.0" esotericsoftware-kryo = "4.0.2" errorprone-annotations = "2.3.3" findbugs-jsr305 = "3.0.2" -flink115 = { strictly = "[1.15, 1.16[", prefer = "1.15.0"} # see rich version usage explanation above -flink116 = { strictly = "[1.16, 1.17[", prefer = "1.16.2"} -flink117 = { strictly = "[1.17, 1.18[", prefer = "1.17.1"} +flink115 = { strictly = "1.15.0"} +flink116 = { strictly = "1.16.2"} +flink117 = { strictly = "1.17.1"} google-libraries-bom = "26.18.0" guava = "32.1.1-jre" hadoop2 = "2.7.3" hadoop3-client = "3.3.6" httpcomponents-httpclient5 = "5.2.1" -hive2 = { strictly = "[2, 3[", prefer = "2.3.9"} # see rich version usage explanation above +hive2 = { strictly = "2.3.9"} hive3 = "3.1.3" immutables-value = "2.9.2" jackson-annotations = "2.15.2" jackson-bom = "2.14.2" jackson-dataformat-xml = "2.9.9" -jackson211 = { strictly = "[2.11, 2.12[", prefer = "2.11.4"} # see rich version usage explanation above -jackson212 = { strictly = "[2.12, 2.13[", prefer = "2.12.3"} -jackson213 = { strictly = "[2.13, 2.14[", prefer = "2.13.4"} -jackson214 = { strictly = "[2.14, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
