flyrain commented on code in PR #9889:
URL: https://github.com/apache/iceberg/pull/9889#discussion_r1520078687
##########
docs/docs/spark-procedures.md:
##########
@@ -756,8 +756,8 @@ Creates a view that contains the changes from a given table.
| `table` | ✔️ | string | Name of the source
table for the changelog
|
| `changelog_view` | | string | Name of the view to
create
|
| `options` | | map<string, string> | A map of Spark read
options to use
|
-| `net_changes` | | boolean | Whether to output
net changes (see below for more information). Defaults to false.
|
-| `compute_updates` | | boolean | Whether to compute
pre/post update images (see below for more information). Defaults to false.
|
+| `net_changes` | | boolean | Whether to output
net changes (see below for more information). Defaults to false. It must be
false when `compute_updates` is true.
|
Review Comment:
`It must be false` -> `It is disabled`?
I feel `It must be false` means users still have an option to enable it, at
least control it. The logic is that it is always disabled when
`compute_updates` is true.
##########
docs/docs/spark-procedures.md:
##########
@@ -823,6 +823,8 @@ second snapshot deleted 1 record.
|2 | Bob |INSERT |0 |5390529835796506035|
|1 | Alice |DELETE |1 |8764748981452218370|
+#### Net Changes
Review Comment:
This is an item under the subtitle `example`, it should not be the same
level as `example`. Can we change it to one level down, like `##### Net
Changes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
