nastra commented on code in PR #9862:
URL: https://github.com/apache/iceberg/pull/9862#discussion_r1517334559
##########
data/src/test/java/org/apache/iceberg/io/TestBaseTaskWriter.java:
##########
@@ -90,23 +93,23 @@ private Record createRecord(Integer id, String data) {
return gRecord.copy("id", id, "data", data);
}
- @Test
+ @TestTemplate
public void testWriteZeroRecord() throws IOException {
try (TestTaskWriter writer = createTaskWriter(128 * 1024 * 1024)) {
writer.close();
WriteResult result = writer.complete();
- Assert.assertEquals(0, result.dataFiles().length);
- Assert.assertEquals(0, result.deleteFiles().length);
+ assertThat(result.dataFiles().length).isEqualTo(0);
Review Comment:
```suggestion
assertThat(result.dataFiles()).isEmpty();
```
or `assertThat(result.dataFiles()).hasSize(0);`
please also update other places in this PR accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
