liurenjie1024 commented on code in PR #228: URL: https://github.com/apache/iceberg-rust/pull/228#discussion_r1513696354
########## crates/iceberg/src/expr/mod.rs: ########## @@ -30,7 +30,7 @@ pub use predicate::*; /// The discriminant of this enum is used for determining the type of the operator, see /// [`PredicateOperator::is_unary`], [`PredicateOperator::is_binary`], [`PredicateOperator::is_set`] #[allow(missing_docs)] -#[derive(Debug, Clone, Copy)] +#[derive(Debug, Clone, Copy, PartialEq)] Review Comment: I think they are also `Eq`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
