ndrluis commented on issue #497: URL: https://github.com/apache/iceberg-python/issues/497#issuecomment-1979024491
I was thinking it would be easier, but I found [a test that makes a table import through the catalog module](https://github.com/apache/iceberg-python/blob/main/tests/integration/test_writes.py#L35), so I think that we might encounter more cases like this. Considering that, and to make it easier to review, I will create one PR for each namespace. I will need some help to determine if something should be public or private. Starting with the catalog, I believe that only `Catalog` and `load_catalog` should be public. Does anyone disagree with this? Another point is that I believe `delete_files` and `delete_data_files` should be private methods of Catalog, but I think we can address this in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
