bitsondatadev commented on code in PR #9861:
URL: https://github.com/apache/iceberg/pull/9861#discussion_r1511432119
##########
format/spec.md:
##########
@@ -791,7 +788,7 @@ Each version of table metadata is stored in a metadata
folder under the table’
Notes:
-1. The file system table scheme is implemented in
[HadoopTableOperations](../../../javadoc/{{ icebergVersion
}}/index.html?org/apache/iceberg/hadoop/HadoopTableOperations.html).
+1. The file system table scheme is implemented in
[HadoopTableOperations](../../javadoc/latest/{{ icebergVersion
}}/index.html?org/apache/iceberg/hadoop/HadoopTableOperations.html).
Review Comment:
It does, I meant to add this as a draft. I'll convert this now.
So the main thing I need to check actually, is if we should have everything
that links to site/docs/*.md files and javadocs/* files to be absolute links
only. I may end up just removing these links and setting up a larger PR to
figure out the best way to deal with absolute links.
In general, mkdocs pushes against absolute links, and it may mess up offline
rendering if we don't follow it. That said, there was a hack we did in the
Trino project, which offered a method to use a global variable that could
either be set to a relative base (e.g. `site_base: '/', docs_base: '../../'`),
or an absolute link (e.g. `site_base: 'https://iceberg.apache.org/'`,
`docs_base: 'https://iceberg.apache.org/'`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
