nk1506 commented on issue #9085: URL: https://github.com/apache/iceberg/issues/9085#issuecomment-1975752088
@tomtongue , I was working with [TestOverwrite](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TestOverwrite.java) and to move this to jUnit5 I had to change [TableTestBase](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TableTestBase.java), which ended up changing all the dependent class. With this [PR](https://github.com/apache/iceberg/pull/9862) I will plan to change only `@ExtendWith(ParameterizedTestExtension.class)` and related issues. It seems it's not allowing me to keep mix of jUnit4 and jUnit5. For the above classes I wont make any changes related to assertions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
