ajantha-bhat commented on code in PR #9822:
URL: https://github.com/apache/iceberg/pull/9822#discussion_r1505808326
##########
.palantir/revapi.yml:
##########
@@ -873,6 +873,10 @@ acceptedBreaks:
new: "method void org.apache.iceberg.encryption.Ciphers::<init>()"
justification: "Static utility class - should not have public
constructor"
"1.4.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.OverwriteFiles
org.apache.iceberg.OverwriteFiles::appendManifest(org.apache.iceberg.ManifestFile)"
+ justification: "Provision to use manifestFile with thousand of data
files together"
Review Comment:
Adding new things should not be a breaking change if you provide it as a
default interface.
Can you try making it as `default` interface which throws
`UnsupportedOperationException`?
And remove this modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
