RussellSpitzer commented on code in PR #9803:
URL: https://github.com/apache/iceberg/pull/9803#discussion_r1504778737
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##########
@@ -111,6 +111,8 @@ public abstract class SizeBasedFileRewriter<T extends
ContentScanTask<F>, F exte
private boolean rewriteAll;
private long maxGroupSize;
+ private int outputSpecId;
Review Comment:
Why not also save the outputSpec as well? I notice we just have to get it a
few times. Maybe it just makes sense as a protected method
```java
outputSpec() {
return table.specs().get(outputSpecId)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
