Fokko commented on code in PR #471:
URL: https://github.com/apache/iceberg-python/pull/471#discussion_r1503909086
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1720,7 +1721,7 @@ def fill_parquet_file_metadata(
data_file.split_offsets = split_offsets
-def write_file(table: Table, tasks: Iterator[WriteTask], file_schema:
Optional[Schema] = None) -> Iterator[DataFile]:
+def write_file(io: FileIO, table_metadata: TableMetadata, tasks:
Iterator[WriteTask]) -> Iterator[DataFile]:
Review Comment:
Yes, this was a workaround to get that test passing. However, I think it was
just a fix for that particular operation where you would first evolve the
schema, and then write in the same transaction. Using the file-schema we could
pass in that newer schema. But I don't think it was the right solution since it
only fixes that specific pattern. Updating the metadata is much more flexible
and safe. For example, if you set some properties, and then do a write, that
would also be picked up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
