kevinjqliu commented on code in PR #469:
URL: https://github.com/apache/iceberg-python/pull/469#discussion_r1503717843
##########
tests/catalog/test_sql.py:
##########
@@ -851,3 +852,39 @@ def test_concurrent_commit_table(catalog: SqlCatalog,
table_schema_simple: Schem
# This one should fail since it already has been updated
with table_b.update_schema() as update:
update.add_column(path="c", field_type=IntegerType())
+
+
+@pytest.mark.parametrize(
+ 'catalog',
+ [
+ lazy_fixture('catalog_memory'),
+ lazy_fixture('catalog_sqlite'),
+ lazy_fixture('catalog_sqlite_without_rowcount'),
+ ],
+)
+def test_table_properties_int_value(catalog: SqlCatalog, table_schema_simple:
Schema, random_identifier: Identifier) -> None:
+ # table properties can be set to int, but still serialized to string
+ database_name, _table_name = random_identifier
+ catalog.create_namespace(database_name)
+ property_with_int = {"property_name": 42}
+ table = catalog.create_table(random_identifier, table_schema_simple,
properties=property_with_int)
+ assert isinstance(table.properties["property_name"], str)
+
+
+@pytest.mark.parametrize(
+ 'catalog',
+ [
+ lazy_fixture('catalog_memory'),
+ lazy_fixture('catalog_sqlite'),
+ lazy_fixture('catalog_sqlite_without_rowcount'),
+ ],
+)
+def test_table_properties_raise_for_none_value(
+ catalog: SqlCatalog, table_schema_simple: Schema, random_identifier:
Identifier
+) -> None:
+ database_name, _table_name = random_identifier
+ catalog.create_namespace(database_name)
+ property_with_none = {"property_name": None}
+ with pytest.raises(ValidationError) as exc_info:
Review Comment:
I believe Pydantic catches the underlying error and reraise a ValidationError
from the [docs](https://docs.pydantic.dev/latest/errors/errors/),
"""
Pydantic will raise a
[ValidationError](https://docs.pydantic.dev/latest/api/pydantic_core/#pydantic_core.ValidationError)
whenever it finds an error in the data it's validating.
Note
Validation code should not raise ValidationError itself, but rather raise a
ValueError or AssertionError (or subclass thereof) which will be caught and
used to populate ValidationError.
"""
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
