rdblue commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1501926170


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,184 @@ components:
           type: integer
           format: int64
 
+    BooleanTypeValue:
+      type: boolean
+
+    IntegerTypeValue:
+      type: integer
+
+    LongTypeValue:
+      type: integer
+      format: int64
+
+    FloatTypeValue:

Review Comment:
   @jackye1995, we should make sure that we produce values correctly and don't 
modify them in serialization or deserialization.
   
   However, for the purpose of this spec I think that it is okay to move 
forward. Both float and double are part of the OpenAPI Spec 
([OAS](https://spec.openapis.org/oas/latest.html#data-types)) so I think they 
can be exchanged correctly. We just need to make sure our implementation is 
doing so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to