nastra commented on code in PR #9787:
URL: https://github.com/apache/iceberg/pull/9787#discussion_r1501368418
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -1335,6 +1335,35 @@ public void showViews() throws NoSuchTableException {
row("global_temp", "globalviewforlisting", true), tempView);
}
+ @Test
+ public void showViewsWithCurrentNamespace() {
+ String namespaceOne = "show_views_ns1";
+ String namespaceTwo = "show_views_ns2";
+ String viewOne = viewName("viewOne");
+ String viewTwo = viewName("viewTwo");
+ sql("CREATE NAMESPACE IF NOT EXISTS %s", namespaceOne);
+ sql("CREATE NAMESPACE IF NOT EXISTS %s", namespaceTwo);
+
+ // create one view in each namespace
+ sql("CREATE VIEW %s.%s AS SELECT * FROM %s.%s", namespaceOne, viewOne,
NAMESPACE, tableName);
+ sql("CREATE VIEW %s.%s AS SELECT * FROM %s.%s", namespaceTwo, viewTwo,
NAMESPACE, tableName);
+
+ Object[] v1 = row(namespaceOne, viewOne, false);
+ Object[] v2 = row(namespaceTwo, viewTwo, false);
+
+ sql("USE %s", namespaceOne);
+ // should only contain v1 but not v2
+ assertThat(sql("SHOW VIEWS")).contains(v1).doesNotContain(v2);
Review Comment:
this specifically uses `contains()` instead of `containsExactly()` because
the result can also contain temp views that were created in other tests because
temp views don't belong to any catalog/namespace and are always listed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
