jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1500924999
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1581,6 +1607,17 @@ components:
type: string
example: [ "accounting", "tax" ]
+ PageToken:
+ description:
+ An opaque token which allows clients to make use of pagination for a
list API (e.g. ListTables).
+ Clients will initiate the first paginated request by sending an empty
`pageToken` e.g. `GET /tables?pageToken` or `GET /tables?pageToken=`
+ signaling to the service that the response should be paginated.
+
+ For servers that support pagination, they will recognize `pageToken`
and return a `next-page-token` in response if there are more results available.
Review Comment:
> I still think the wording can be improved in this section to avoid using
they to refer to servers. I did a previous suggestion which avoids using they
+1
> additionally it's confusing to use pageToken and next-page-token (vs
nextPageToken), so which one is correct here?
I think we probably have to use `next-page-token` instead of
`nextPageToken`, because it is the actual field name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
