zachdisc commented on code in PR #9731: URL: https://github.com/apache/iceberg/pull/9731#discussion_r1500913132
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java: ########## @@ -90,13 +94,13 @@ public class RewriteManifestsSparkAction public static final String USE_CACHING = "use-caching"; public static final boolean USE_CACHING_DEFAULT = false; + private List<String> partitionSortColumns = null; Review Comment: Is this a problem? I have these attributes as being set to `null` but able to be redefined. So I think `private` is correct here, its inline with the other attributes in this class. I do have this attribute in the wrong place though, moving in next rev. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
