nastra commented on code in PR #9770:
URL: https://github.com/apache/iceberg/pull/9770#discussion_r1497721799


##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -140,7 +140,6 @@ private JdbcCatalog initCatalog(String catalogName, 
Map<String, String> props) {
 
     properties.put(JdbcCatalog.PROPERTY_PREFIX + "username", "user");
     properties.put(JdbcCatalog.PROPERTY_PREFIX + "password", "password");
-    properties.put(JdbcUtil.SCHEMA_VERSION_PROPERTY, 
JdbcUtil.SchemaVersion.V1.name());

Review Comment:
   for other reviewers: this was changed so that the default tests all run with 
schem V0 (not view-aware). We then decided to add a separate test class that 
runs all catalog tests with schema V1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to