rdblue commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496220389
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -140,6 +139,7 @@ public void initialize(String name, Map<String, String>
properties) {
if (initializeCatalogTables) {
initializeCatalogTables();
}
+ checkAndMaybeUpdateSchema();
Review Comment:
I think it is odd that this always initializes the catalog with view support
when not all clients support views. Instead of an upgrade flag, I would expect
this to be configured by a schema version using something like
`schema.version={0,1}` that defaults to 0. Then initialization would always
know which table to create and upgrading would be done with `schema.version`
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
