rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1495091041
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+ PlanTask:
+ description:
+ A JSON object that contains information provided by the server,
+ to be utilized by clients for distributed planning, should be supplied
+ as is for input in PlanTable operation.
+ type: object
+
+ FileScanTask:
+ type: object
+ required:
+ - schema
+ - spec
+ - start
+ - length
+ - data-file
+ properties:
+ data-file:
+ $ref: '#/components/schemas/ContentFile'
+ partition:
+ type: object
+ additionalProperties:
+ type: string
+ size-bytes:
+ type: number
+ start:
+ type: number
+ length:
+ type: number
+ estimated-rows-count:
+ type: number
+ delete-files:
+ type: array
+ items:
+ $ref: '#/components/schemas/ContentFile'
+ schema:
+ $ref: '#/components/schemas/Schema'
Review Comment:
When modeling this, I referred to the `FileScanTaskParser`
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/FileScanTaskParser.java
, which contains a field `SCHEMA`, that seems to not be null
```
private static final String SCHEMA = "schema";
generator.writeFieldName(SCHEMA);
SchemaParser.toJson(fileScanTask.schema(), generator);
```
For the type of schema it looks to be a table schema, my assumption is that
the FileScanTaskParser is off of the BaseFileScanTask which has a reference to
this Schema class. @stevenzwu
```
/**
* The schema of a data table.
*
* <p>Schema ID will only be populated when reading from/writing to table
metadata, otherwise it
* will be default to 0.
*/
public class Schema implements Serializable {
```
https://github.com/apache/iceberg/blob/5b84f34a5386fc61b17bfe7dc7c1cbe565550958/api/src/main/java/org/apache/iceberg/Schema.java#L51
As
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
