jackye1995 commented on code in PR #9660:
URL: https://github.com/apache/iceberg/pull/9660#discussion_r1495059509


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1581,6 +1607,17 @@ components:
         type: string
       example: [ "accounting", "tax" ]
 
+    PageToken:
+      description:
+        An opaque token which allows clients to make use of pagination for a 
list API (e.g. ListTables) by signaling to the service

Review Comment:
   What about the following:
   
   ```
   An opaque token which allows clients to make use of pagination for a list 
API (e.g. ListTables). Clients will initiate the first paginated request by 
sending an empty pageToken e.g. `GET /tables?pageToken` or `GET 
/tables?pageToken=`, signaling to the service that the response should be 
paginated.
   ```



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1581,6 +1607,17 @@ components:
         type: string
       example: [ "accounting", "tax" ]
 
+    PageToken:
+      description:
+        An opaque token which allows clients to make use of pagination for a 
list API (e.g. ListTables) by signaling to the service

Review Comment:
   What about the following:
   
   An opaque token which allows clients to make use of pagination for a list 
API (e.g. ListTables). Clients will initiate the first paginated request by 
sending an empty pageToken e.g. `GET /tables?pageToken` or `GET 
/tables?pageToken=`, signaling to the service that the response should be 
paginated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to