rdblue commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1494918141
########## open-api/rest-catalog-open-api.yaml: ########## @@ -2800,6 +3053,59 @@ components: additionalProperties: type: string + PlanContext: + type: object + required: + - select + - options + properties: + select: + description: A list of the selected columns + type: array + items: + type: string + project: + description: A list of the projections + type: array + items: + type: string + filter: + $ref: '#/components/schemas/Expression' + options: + type: object + additionalProperties: + type: string + use-snapshot: + type: integer + format: int64 + from-snapshot-id: + type: integer + format: int64 + to-snapshot-id: + type: integer + format: int64 + as-of-time: + type: integer + format: int64 + case-sensitive: + type: boolean + use-ref: + type: string + + PreplanTableRequest: + type: object + properties: + allOf: Review Comment: I would not include the `stats-fields` list in this request. That option only applies when producing scan tasks. Given I think that I would not use `PlanContext` given that this is a subset of the arguments and the addition of `plan-task` below changes whether other arguments like `snapshot-id` are allowed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org