stevenzwu commented on code in PR #9728:
URL: https://github.com/apache/iceberg/pull/9728#discussion_r1493034865
##########
core/src/main/java/org/apache/iceberg/FileScanTaskParser.java:
##########
@@ -21,116 +21,84 @@
import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.databind.JsonNode;
import java.io.IOException;
-import org.apache.iceberg.expressions.Expression;
-import org.apache.iceberg.expressions.ExpressionParser;
-import org.apache.iceberg.expressions.Expressions;
-import org.apache.iceberg.expressions.ResidualEvaluator;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+import org.apache.iceberg.relocated.com.google.common.base.Strings;
import org.apache.iceberg.util.JsonUtil;
public class FileScanTaskParser {
- private static final String SCHEMA = "schema";
- private static final String SPEC = "spec";
- private static final String DATA_FILE = "data-file";
- private static final String START = "start";
- private static final String LENGTH = "length";
- private static final String DELETE_FILES = "delete-files";
- private static final String RESIDUAL = "residual-filter";
+ private static final String TASK_TYPE = "task-type";
+
+ private enum TaskType {
Review Comment:
@jackye1995 I agree that `ScanTaskParser` is more accurate for the
facade/dispatcher class here. The only problem is that `FileScanTaskParser` is
a public class in core module. Technically, we are breaking compatibility.
maybe we can keep `FileScanTaskParser` and mark it as deprecated. it can
just extend from the new `ScanTaskParser` to avoid code duplication. But it
means that we need to keep the file task parser name as
`BaseFileScanTaskParser`, which is package private anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
