pvary commented on code in PR #9735:
URL: https://github.com/apache/iceberg/pull/9735#discussion_r1492832463
##########
core/src/main/java/org/apache/iceberg/MetadataTableUtils.java:
##########
@@ -32,9 +32,16 @@ public static boolean hasMetadataTableName(TableIdentifier
identifier) {
public static Table createMetadataTableInstance(Table table,
MetadataTableType type) {
if (table instanceof BaseTable) {
return createMetadataTableInstance(table,
metadataTableName(table.name(), type), type);
+ } else if (table instanceof HasTableOperations) {
+ return createMetadataTableInstance(
+ ((HasTableOperations) table).operations(),
+ table.name(),
+ metadataTableName(table.name(), type),
+ type);
} else {
throw new IllegalArgumentException(
- String.format("Cannot create metadata table for table %s: not a base
table", table));
+ String.format(
Review Comment:
Changed as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
