zeroshade commented on code in PR #58:
URL: https://github.com/apache/iceberg-go/pull/58#discussion_r1488412489
##########
catalog/catalog.go:
##########
@@ -47,19 +52,136 @@ func WithAwsConfig(cfg aws.Config) Option {
}
}
+func WithCredential(cred string) Option {
Review Comment:
@wolfeidau take a look at the way I've set up some interesting little
generic stuff in the most recent commit making the `Options` typed so that we
can specify options which are explicit for one catalog or the other without
having to do a ton of duplication. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
