Fokko opened a new pull request, #413: URL: https://github.com/apache/iceberg-python/pull/413
This reverts commit e9e265a1878a55a4385580bf800382fd75c912c9. If I'm reading [the page right](https://infra.apache.org/licensing-howto.html), the following justifies the NOTICE updates: > If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file. And: > It is not necessary to duplicate the line "This product includes software developed at the Apache Software Foundation...", though the ASF copyright line and any other portions of NOTICE must be considered for propagation. So the License itself needs to be propagated. Below it states: > Aside from Apache-licensed dependencies which supply NOTICE files of their own, it is uncommon for a dependency to require additions to NOTICE. So I think we should update the NOTICE to mention Avro, Thrift, and Hive. > Assuming that the bundled dependency itself contains no bundled sub-components under other licenses, so the ALv2 applies uniformly to all files, there is no need to modify LICENSE. However, for completeness it is useful to list the products and their versions, as is done for products under other licenses. For completeness, I think it is good to have the LICENSE as we had it before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
