Fokko commented on issue #398: URL: https://github.com/apache/iceberg-python/issues/398#issuecomment-1934910609
Thanks for raising this @jqin61. The date is a logical type, where the integer represents the days since 1-1-1970. To public APIs, we should accept `datetime.date` for convenience. Then we should convert it internally: https://github.com/apache/iceberg-python/blob/7a1fe28df38bfdc69166915dca49cfde660853bf/pyiceberg/utils/datetime.py#L55-L57 Onto how to resolve this. I would lean to 1. since this is not publically exposed. We can just keep it an integer internally (this makes comparisons easier). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
