castedice commented on issue #344: URL: https://github.com/apache/iceberg-python/issues/344#issuecomment-1931497403
This week was a tough week and I didn't have time to work on it. I'll try to submit a PR tomorrow or the day after. The way you support `large_string` in #382 is similar to how I was thinking of doing it. Alternatively, I was thinking of replacing all binary types with large_binary. That seems like a much simpler way to do it, although the memory allocated to the pyarrow object would be a bit larger in that case (in terms of modifying the test code, I suppose it might be more work). In terms of tight memory management, it seems like it might be a solution you'd be reluctant to go with - I'd be interested in your thoughts. @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
