nk1506 commented on PR #9461: URL: https://github.com/apache/iceberg/pull/9461#issuecomment-1929402938
> Hi , I am sorry for the late reply. > > I left some more comments and explanations of preivous comments. > > I am also now thinking, whether it makes sense to have a common interface for TableMetadata and ViewMetadata, as @pvary originally suggested. Something like HasLocations or HasProperties may help us already remove lots of duplicate code here. There is already precdent in Table => HasTableOperations, and many other interfaces in Iceberg code, and should not be very visible to the user. We already have a thread for the same https://github.com/apache/iceberg/issues/9514. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org