anupam-saini commented on code in PR #340:
URL: https://github.com/apache/iceberg-python/pull/340#discussion_r1478267337
##########
pyiceberg/catalog/rest.py:
##########
@@ -472,6 +488,7 @@ def create_table(
table_response = TableResponse(**response.json())
return self._response_to_table(self.identifier_to_tuple(identifier),
table_response)
+ @retry(retry=retry_if_exception_type(AuthorizationExpiredError),
stop=stop_after_attempt(2), before=_retry_hook, reraise=True)
Review Comment:
Thanks @Fokko for taking time to review this.
- That's a good point and I agree with your intention of keeping the retry
logic to a minimal. I put some thought into how I'd need to implement it if we
want to put it in `_handle_non_200_response`, but by the time we reach that
method, we've lost the caller and the request that was sent. Hence, the next
best thing I could come up was to remove the retry argument duplicates all over
and keep it to a minimal.
- My bad that I missed `_commit_table()` added the functionality there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
