HonahX commented on code in PR #366:
URL: https://github.com/apache/iceberg-python/pull/366#discussion_r1477752559
##########
pyiceberg/catalog/glue.py:
##########
@@ -150,7 +152,7 @@ def primitive(self, primitive: PrimitiveType) -> str:
if isinstance(primitive, DecimalType):
return f"decimal({primitive.precision},{primitive.scale})"
if (primitive_type := type(primitive)) not in GLUE_PRIMITIVE_TYPES:
- raise ValueError(f"Unknown primitive type: {primitive}")
+ return str(primitive_type.root)
Review Comment:
Since this is only for the StorageDescriptor, which is optional, I think it
should not block the table creation even when encountering unknown primitive
types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
